Page MenuHomePhabricator

Fix D2181 by including DumpRPC
ClosedPublic

Authored by deadalnix on May 14 2019, 21:42.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0cd601821488: Fix D2181 by including DumpRPC
Summary

As per title. The backport did not take into account modification that were done to our codebase.

Test Plan
make check
test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
walletdumprpc
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5851
Build 9762: Bitcoin ABC Teamcity Staging
Build 9761: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 14 2019, 21:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2019, 21:42
Fabien requested changes to this revision.May 16 2019, 11:35
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/rpcdump.cpp
1473

My understanding is that -disablewallet can be set even if ENABLE_WALLET is set (and wallet is compiled).
I would keep that one to avoid issues.

Note: there seems to be a DEFAULT_DISABLE_WALLET which can be used instead of false (for another diff).

This revision now requires changes to proceed.May 16 2019, 11:35
deadalnix requested review of this revision.May 16 2019, 12:30
deadalnix added inline comments.
src/wallet/rpcdump.cpp
1473

The check is performed in WalletInit::RegisterRPC .

This follow the pattern in D2181 . It's not the responsibility of the function that register command to check for user level configurations.

Fabien accepted this revision.May 16 2019, 12:31
This revision is now accepted and ready to land.May 16 2019, 12:31
This revision was automatically updated to reflect the committed changes.