Page MenuHomePhabricator

[wallet] Remove Wallet dependencies from init.cpp
ClosedPublic

Authored by Fabien on Dec 7 2018, 15:52.

Details

Summary

From core : This PR, along with several others, would remove the remaining dependencies from libbitcoin_server.a on libbitcoin_wallet.a.

Depends on D2180

Backport of core PR10762

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Dec 7 2018, 15:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 7 2018, 15:52
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Dec 7 2018, 20:12

Some small nits, but overall it's good.

src/init.cpp
47 ↗(On Diff #6294)

Clearly, there was a backport missed here. No big deal, but please figure out which it is.

src/wallet/init.h
38 ↗(On Diff #6294)

Fix comment layout

This revision now requires changes to proceed.Dec 7 2018, 20:12
Fabien marked an inline comment as done.Dec 7 2018, 20:44
Fabien updated this revision to Diff 6297.

Fix comment layout

src/init.cpp
47 ↗(On Diff #6294)

You created this file in commit 00f4b659f3c497bbcd00447221d808b3b2cf0180
There might be something to do to remove this ENABLE_WALLET though, but it is out of scope for this backport.

deadalnix added inline comments.Dec 7 2018, 20:58
src/init.cpp
47 ↗(On Diff #6294)

Ha ok :)

deadalnix accepted this revision.Dec 7 2018, 20:59
This revision is now accepted and ready to land.Dec 7 2018, 20:59
This revision was automatically updated to reflect the committed changes.