Page MenuHomePhabricator
Differential D3048

wallet: Refactor g_wallet_init_interface to const reference
ClosedPublic
Actions

Authored by deadalnix on May 14 2019, 22:40.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING9aa686d254d1: wallet: Refactor g_wallet_init_interface to const reference
rABC9aa686d254d1: wallet: Refactor g_wallet_init_interface to const reference
Summary

This is the second part of Core PR12977 : https://github.com/bitcoin/bitcoin/pull/12977/commits/6ec78f146134be7ee067a25a412d3c927f9ac353

Depends on D3045 and D3047

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
gwalletconstref
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5869
Build 9798: Bitcoin ABC Buildbot (legacy)
Build 9797: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 14 2019, 22:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2019, 22:40
teamcity added a comment.May 14 2019, 22:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5854: Diff 8666.May 14 2019, 22:54
teamcity added a comment.May 14 2019, 22:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.May 16 2019, 11:58
This revision is now accepted and ready to land.May 16 2019, 11:58
deadalnix updated this revision to Diff 8691.May 16 2019, 12:40

rebase

teamcity added a comment.May 16 2019, 12:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

This revision was landed with ongoing or failed builds.May 16 2019, 12:53
Closed by commit rABC9aa686d254d1: wallet: Refactor g_wallet_init_interface to const reference (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.May 16 2019, 12:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5869: Diff 8691.May 16 2019, 12:55
deadalnix added a commit: rSTAGING9aa686d254d1: wallet: Refactor g_wallet_init_interface to const reference.Sep 18 2019, 23:34

Revision Contents
Changeset List

PathSize
src/
2 lines
21 lines
wallet/
3 lines

Diff 8691

View Options

src/init.h

Loading...
View Options

src/init.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...