Page MenuHomePhabricator

Fix more init bugs.
ClosedPublic

Authored by Fabien on Wed, May 15, 11:15.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCc7f22f815621: Fix more init bugs.
Summary

This is a follow-on to #10758 to help move 10758 along. The first fixes
a regression in master that was partially fixed in 10758, the second I'm
not sure if its a regression or not, but its clearly a bug that should
be fixed.

Backport of core PR10919
https://github.com/bitcoin/bitcoin/pull/10919/files

Note to reviewers:
The change in src/bitcoind.cpp is not backported as it should have
been removed in D2260.
Also some of the changes in src/init.cpp have already been (mistakenly
?) ported in D1910.

Test Plan

Run with and without debug:

make check
test_runner.py # should pass without debug, and start but fail on some tests with debug enabled

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, May 15, 11:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, May 15, 11:15
Fabien edited the test plan for this revision. (Show Details)Wed, May 15, 11:16
deadalnix accepted this revision.Wed, May 15, 11:19
This revision is now accepted and ready to land.Wed, May 15, 11:19
This revision was automatically updated to reflect the committed changes.