Page MenuHomePhabricator

Fix more init bugs.
ClosedPublic

Authored by Fabien on May 15 2019, 11:15.

Details

Summary

This is a follow-on to #10758 to help move 10758 along. The first fixes
a regression in master that was partially fixed in 10758, the second I'm
not sure if its a regression or not, but its clearly a bug that should
be fixed.

Backport of core PR10919
https://github.com/bitcoin/bitcoin/pull/10919/files

Note to reviewers:
The change in src/bitcoind.cpp is not backported as it should have
been removed in D2260.
Also some of the changes in src/init.cpp have already been (mistakenly
?) ported in D1910.

Test Plan

Run with and without debug:

make check
test_runner.py # should pass without debug, and start but fail on some tests with debug enabled

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10919
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5858
Build 9776: Bitcoin ABC Buildbot (legacy)
Build 9775: arc lint + arc unit