qa: Cache only chain and wallet for regtest datadir
ClosedPublic
Actions

Authored by Fabien on May 21 2019, 13:57.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING7829a989bc27: qa: Cache only chain and wallet for regtest datadir
rABC7829a989bc27: qa: Cache only chain and wallet for regtest datadir

Summary

Backport of core PR12638
https://github.com/bitcoin/bitcoin/pull/12638/files

Test Plan

./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12638

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5924
Build 9908: Bitcoin ABC Buildbot (legacy)
Build 9907: arc lint + arc unit

Event Timeline

Fabien created this revision.May 21 2019, 13:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2019, 13:58

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5924: Diff 8777.May 21 2019, 14:12

Oh man, does this explain the build failure I have had on D3076?? It was so confusing...

(see - https://build.bitcoinabc.org/repository/download/BitcoinABC_BitcoinAbcStaging/13987:id/test-output.tar.gz%21/bitcoin_test_runner_20190520_183115/cache/test_framework.log )

I looked at D3076 and this seems plausible that this diff solves it indirectly:
it failed to remove wallets/db.log because the whole datadir tree is removed in the test before the node gets restarted, and I suppose that the init error due to the invalid block directory exits the node before the db.log file gets recreated.

You should rebase to be sure !

markblundeberg mentioned this in D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.May 21 2019, 15:52

deadalnix accepted this revision.May 21 2019, 21:48

This revision is now accepted and ready to land.May 21 2019, 21:48

Closed by commit rABC7829a989bc27: qa: Cache only chain and wallet for regtest datadir (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyMay 22 2019, 09:44

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7829a989bc27: qa: Cache only chain and wallet for regtest datadir.

Fabien added a commit: rSTAGING7829a989bc27: qa: Cache only chain and wallet for regtest datadir.Sep 18 2019, 23:40