Page MenuHomePhabricator
Differential D3084

[tests] bind functional test nodes to 127.0.0.1
ClosedPublic
Actions

Authored by Fabien on May 21 2019, 17:13.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGd3226c55b912: [tests] bind functional test nodes to 127.0.0.1
rABCd3226c55b912: [tests] bind functional test nodes to 127.0.0.1
Summary

Prevents OSX firewall
allow-this-application-to-accept-inbound-connections
permission popups and is generally safer.

To prevent binding to 127.0.0.1, set self.bind_to_localhost_only =
False.

Backport of core PR12482
https://github.com/bitcoin/bitcoin/pull/12482/files

Depends on D3090 (prevent failure in abc-high_priority_transaction, see the CI build log).

Test Plan
./test/functional/test_runner.py --extended

Also run on OSX

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 21 2019, 17:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2019, 17:13
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 21 2019, 17:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien retitled this revision from [tests] bind functional test nodes to 127.0.0.1 to [WIP][tests] bind functional test nodes to 127.0.0.1.May 21 2019, 17:15

WIP until I completed the tests on OSX

Harbormaster failed remote builds in B5927: Diff 8781!May 21 2019, 17:26
teamcity added a comment.May 21 2019, 17:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Fabien retitled this revision from [WIP][tests] bind functional test nodes to 127.0.0.1 to [tests] bind functional test nodes to 127.0.0.1.May 21 2019, 20:34

Tested OK on OSX. Revealed another unrelated issue that will be fixed in another diff.

deadalnix accepted this revision.May 21 2019, 21:46
This revision is now accepted and ready to land.May 21 2019, 21:46
Fabien mentioned this in D3090: Avoid calling add_nodes multiple times in functional tests.May 22 2019, 09:49
Fabien edited the summary of this revision. (Show Details)
Fabien added a parent revision: D3090: Avoid calling add_nodes multiple times in functional tests.
Fabien updated this revision to Diff 8799.May 22 2019, 09:51

Rebase on top of D3090.

teamcity added a comment.May 22 2019, 09:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5935: Diff 8799.May 22 2019, 10:06
teamcity added a comment.May 22 2019, 10:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABCd3226c55b912: [tests] bind functional test nodes to 127.0.0.1 (authored by Sjors Provoost <sjors@sprovoost.nl>, committed by Fabien). · Explain WhyMay 22 2019, 16:59
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in rABC0fa2e20dcc12: Avoid calling add_nodes multiple times in functional tests.
Fabien added a commit: rABCd3226c55b912: [tests] bind functional test nodes to 127.0.0.1.
Fabien added a commit: rSTAGINGd3226c55b912: [tests] bind functional test nodes to 127.0.0.1.Sep 18 2019, 23:40
Fabien mentioned this in rSTAGING0fa2e20dcc12: Avoid calling add_nodes multiple times in functional tests.

Revision Contents
Changeset List

PathSize
test/
functional/
1 line
test_framework/
15 lines
5 lines
7 lines
2 lines
2 lines

Diff 8804

View Options

test/functional/rpc_bind.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...
View Options

test/functional/wallet_dump.py

Loading...
View Options

test/functional/wallet_import_rescan.py

Loading...