Page MenuHomePhabricator

Avoid calling add_nodes multiple times in functional tests
ClosedPublic

Authored by Fabien on May 22 2019, 09:39.

Details

Summary

The framework is designed so that nodes are created once and can then be
started/stopped when needed. The add_nodes method should only be
called once when overriding setup_nodes or setup_network.
Doing otherwise causes a failure when trying to bind the newly
added node to the same address/port than a previous one after D3084 is landed.

Test Plan

Run on Linux and OSX:

./test/functional/test_runner.py abc-high_priority_transaction.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 22 2019, 16:07