Page MenuHomePhabricator
Differential D3102

Don't create another wallet db directory in walletdb_tests
ClosedPublic
Actions

Authored by Fabien on May 24 2019, 10:20.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGdebe4fb69ad8: Don't create another wallet db directory in walletdb_tests
rABCdebe4fb69ad8: Don't create another wallet db directory in walletdb_tests
Summary

The walletdb_tests test cases start by creating a wallet db file in a
new directory. Now that the wallet test fixture is used (D3099), this
can be avoided by using the test fixture pwalletMain db instead.

Test Plan
./src/test/test_bitcoin -t walletdb_tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove_facilities_walletdb_tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5966
Build 9992: Bitcoin ABC Buildbot (legacy)
Build 9991: arc lint + arc unit

Event Timeline

Fabien created this revision.May 24 2019, 10:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 24 2019, 10:20
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 24 2019, 10:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5966: Diff 8846.May 24 2019, 10:36
teamcity added a comment.May 24 2019, 10:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien added a child revision: D3103: Allow wallet files in multiple directories.May 24 2019, 14:06
deadalnix accepted this revision.May 26 2019, 19:56
This revision is now accepted and ready to land.May 26 2019, 19:56
deadalnix requested changes to this revision.May 26 2019, 19:57

The test are not independent of each other anymore.

This revision now requires changes to proceed.May 26 2019, 19:57
Fabien requested review of this revision.May 27 2019, 07:35

The test fixture is created/destructed on a test case basis, so the tests remain independent.

deadalnix accepted this revision.May 27 2019, 15:21
This revision is now accepted and ready to land.May 27 2019, 15:21
Closed by commit rABCdebe4fb69ad8: Don't create another wallet db directory in walletdb_tests (authored by Fabien). · Explain WhyMay 27 2019, 15:53
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCdebe4fb69ad8: Don't create another wallet db directory in walletdb_tests.
Fabien added a commit: rSTAGINGdebe4fb69ad8: Don't create another wallet db directory in walletdb_tests.Sep 18 2019, 23:48

Revision Contents
Changeset List

PathSize
src/
wallet/
test/
23 lines

Diff 8846

View Options

src/wallet/test/walletdb_tests.cpp

Loading...