Page MenuHomePhabricator

Don't create another wallet db directory in walletdb_tests
ClosedPublic

Authored by Fabien on May 24 2019, 10:20.

Details

Summary

The walletdb_tests test cases start by creating a wallet db file in a
new directory. Now that the wallet test fixture is used (D3099), this
can be avoided by using the test fixture pwalletMain db instead.

Test Plan
./src/test/test_bitcoin -t walletdb_tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove_facilities_walletdb_tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5966
Build 9992: Bitcoin ABC Buildbot (legacy)
Build 9991: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 26 2019, 19:56
deadalnix requested changes to this revision.May 26 2019, 19:57

The test are not independent of each other anymore.

This revision now requires changes to proceed.May 26 2019, 19:57
Fabien requested review of this revision.May 27 2019, 07:35

The test fixture is created/destructed on a test case basis, so the tests remain independent.

This revision is now accepted and ready to land.May 27 2019, 15:21