Merge #10341: rpc/wallet: Workaround older UniValue which returns a std::string temporary for get_str
ClosedPublic
Actions

Authored by jasonbcox on May 24 2019, 18:08.

Details

Reviewers

deadalnix
Fabien
markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGING8c74fb8597cc: Merge #10341: rpc/wallet: Workaround older UniValue which returns a std::string…
rABC8c74fb8597cc: Merge #10341: rpc/wallet: Workaround older UniValue which returns a std::string…

Summary

a637734 rpc/wallet: Workaround older UniValue which returns a std::string temporary for get_str (Luke Dashjr)

Tree-SHA512: 8f03f1d301f714f700bf64e259a1c986136fd1ac532f091aa97198a39c131290c320094f4fc38c774c8db4469a75437596b1d933300e4f04037abc158a252bad

Backport of Core PR10341
https://github.com/bitcoin/bitcoin/pull/10341/files

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.May 24 2019, 18:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 24 2019, 18:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5974: Diff 8858.May 24 2019, 18:23

Fabien accepted this revision.May 25 2019, 07:37

This revision is now accepted and ready to land.May 25 2019, 07:37

Closed by commit rABC8c74fb8597cc: Merge #10341: rpc/wallet: Workaround older UniValue which returns a std::string… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMay 27 2019, 06:07

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC8c74fb8597cc: Merge #10341: rpc/wallet: Workaround older UniValue which returns a std::string….

jasonbcox added a commit: rSTAGING8c74fb8597cc: Merge #10341: rpc/wallet: Workaround older UniValue which returns a std::string….Sep 18 2019, 23:47

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

6 lines

Diff 8905

View Options

Merge #10341: rpc/wallet: Workaround older UniValue which returns a std::string temporary for get_strClosedPublicActions