Differential D3117

[script] Unit tests for IsMine
ClosedPublic
Actions

Authored by deadalnix on May 26 2019, 17:49.

Details

Reviewers

markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGINGb4504f19e52a: [script] Unit tests for IsMine
rABCb4504f19e52a: [script] Unit tests for IsMine

Summary

Does not test watch-only addresses.

This is partial backport of Core PR11116 : https://github.com/bitcoin/bitcoin/pull/11116/commits/7a1e873b27b790c965d9927ecd465710dc103136

Depends on D3116

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 26 2019, 17:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2019, 17:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5989: Diff 8882.May 26 2019, 18:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Looks good; some segwit tests removed of course but otherwise verbatim.

This revision is now accepted and ready to land.May 27 2019, 00:51

Closed by commit rABCb4504f19e52a: [script] Unit tests for IsMine (authored by jimpo, committed by deadalnix). · Explain WhyMay 27 2019, 01:17

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCb4504f19e52a: [script] Unit tests for IsMine.

deadalnix added a commit: rSTAGINGb4504f19e52a: [script] Unit tests for IsMine.Sep 18 2019, 23:47

Revision Contents
Changeset List

Path

Size

src/

script/

ismine.cpp

2 lines

test/

script_standard_tests.cpp

208 lines

Diff 8898

View Options

src/script/ismine.cpp