(finally) remove getinfo in favor of more module-specific infos
ClosedPublic
Actions

Authored by deadalnix on May 27 2019, 01:22.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGbf7fc5c03679: (finally) remove getinfo in favor of more module-specific infos
rABCbf7fc5c03679: (finally) remove getinfo in favor of more module-specific infos

Summary

This is backport of Core PR10838

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 27 2019, 01:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2019, 01:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

no release note?

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5998: Diff 8899.May 27 2019, 01:37

We should also backport this: https://github.com/bitcoin/bitcoin/pull/12198

I think a release note is well-deserved here. Yeah, I know it's been deprecated for 3 years already but I didn't even realize that until I read the help text just now. =D

(also, I can backport the follow up PR that gives helpful error, or do you want to do that?)

This revision now requires changes to proceed.May 27 2019, 14:18

Hmm... also since the new txindex code was landed, maybe defer this to next release? If someone has to downgrade because their project relies on removed RPC for some bizarre reason, they'll be pissed if they have to reindex the txindex.

Ok we can wait 3 days.

deadalnix added a child revision: D3138: [rpc] split wallet and non-wallet parts of DescribeAddressVisitor.May 28 2019, 00:49

markblundeberg accepted this revision.Jun 1 2019, 13:46

This revision is now accepted and ready to land.Jun 1 2019, 13:46

OK should be good to go! Will you backport https://github.com/bitcoin/bitcoin/pull/12198 as well, or shall I?