Page MenuHomePhabricator
Differential D3139

[rpc] Move DescribeAddressVisitor to rpc/util
ClosedPublic
Actions

Authored by deadalnix on May 28 2019, 00:53.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGING721227f91cc0: [rpc] Move DescribeAddressVisitor to rpc/util
rABC721227f91cc0: [rpc] Move DescribeAddressVisitor to rpc/util
Summary

This is a partial backport of Core PR10583 : https://github.com/bitcoin/bitcoin/pull/10583/commits/1598f32304cd55b83ecc623ee0f9e30b4e087b7d

It was somewhat reworked because the original PR doesn't build at all.

Depends on D3138

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 28 2019, 00:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2019, 00:53
teamcity added a comment.May 28 2019, 00:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 28 2019, 01:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6029: Diff 8946.May 28 2019, 01:08
markblundeberg accepted this revision.May 28 2019, 02:20
This revision is now accepted and ready to land.May 28 2019, 02:20
deadalnix added a child revision: D3147: Deprecate parts of validateaddress and introduce getaddressinfo.May 28 2019, 23:43
Closed by commit rABC721227f91cc0: [rpc] Move DescribeAddressVisitor to rpc/util (authored by John Newbery <john@johnnewbery.com>, committed by deadalnix). · Explain WhyJun 2 2019, 22:38
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC721227f91cc0: [rpc] Move DescribeAddressVisitor to rpc/util.
deadalnix added a commit: rSTAGING721227f91cc0: [rpc] Move DescribeAddressVisitor to rpc/util.Sep 18 2019, 23:57
Fabien mentioned this in D5074: Pass chain and client variables where needed.Jan 27 2020, 09:27

Revision Contents
Changeset List

PathSize
src/
1 line
1 line
rpc/
40 lines
3 lines
29 lines

Diff 9075

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/util.h

Loading...
View Options

src/rpc/util.cpp

Loading...