Page MenuHomePhabricator

qa: Use node.datadir instead of tmpdir in test framework
ClosedPublic

Authored by Fabien on May 27 2019, 12:25.

Details

Summary
Commit c53c983 introduced the utility function get_datadir_path, however
not all places in the code use this util function.
Using the util function everywhere makes it easier to review pull
requests related to the datadir.

This commit replaces datadir path creation with the datadir member of
TestNode, which itself uses get_datadir_path.

Backport of core PR12076
https://github.com/bitcoin/bitcoin/pull/12076/files

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12076
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6005
Build 10069: Bitcoin ABC Buildbot (legacy)
Build 10068: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.May 27 2019, 14:33

You need to port the abc-* series of tests as well.

This revision now requires changes to proceed.May 27 2019, 14:33
Fabien requested review of this revision.May 27 2019, 15:02

There is no such case in abc-* tests

This revision is now accepted and ready to land.May 27 2019, 15:20