Page MenuHomePhabricator
Differential D3126

Merge #14510: Avoid triggering undefined behaviour in base_uint<BITS>::bits()
ClosedPublic
Actions

Authored by markblundeberg on May 27 2019, 14:31.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf3b09e4716ca: Merge #14510: Avoid triggering undefined behaviour in base_uint<BITS>::bits()
rABCf3b09e4716ca: Merge #14510: Avoid triggering undefined behaviour in base_uint<BITS>::bits()
Summary

PR14510 backport https://github.com/bitcoin/bitcoin/pull/14510/files
96f6dc9fc50b1cc59e26d50940ebf46e1bdcc0ba Avoid triggering undefined behaviour in base_uint<BITS>::bits() (practicalswift)

Pull request description:

Avoid triggering undefined behaviour in `base_uint<BITS>::bits()`.

`1 << 31` is undefined behaviour in C++11.

Given the reasonable assumption of `sizeof(int) * CHAR_BIT == 32`.
Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.May 27 2019, 14:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2019, 14:31
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 27 2019, 14:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.May 27 2019, 14:34
This revision is now accepted and ready to land.May 27 2019, 14:34
Harbormaster completed remote builds in B6007: Diff 8913.May 27 2019, 14:46
teamcity added a comment.May 27 2019, 14:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABCf3b09e4716ca: Merge #14510: Avoid triggering undefined behaviour in base_uint<BITS>::bits() (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 27 2019, 15:00
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCf3b09e4716ca: Merge #14510: Avoid triggering undefined behaviour in base_uint<BITS>::bits().
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGf3b09e4716ca: Merge #14510: Avoid triggering undefined behaviour in base_uint<BITS>::bits().Sep 18 2019, 23:48

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 8917

View Options

src/arith_uint256.cpp

Loading...