Page MenuHomePhabricator
Differential D3127

Merge #14513: Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG
ClosedPublic
Actions

Authored by markblundeberg on May 27 2019, 14:37.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING92889d584b61: Merge #14513: Avoid 1 << 31 (UB) in calculation of…
rABC92889d584b61: Merge #14513: Avoid 1 << 31 (UB) in calculation of…
Summary

PR14513 backport https://github.com/bitcoin/bitcoin/pull/14513/files
bc60c615a5 Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG (practicalswift)

Pull request description:

Avoid `1 << 31` (UB) in calculation of `SEQUENCE_LOCKTIME_DISABLE_FLAG`.

Context: https://github.com/bitcoin/bitcoin/pull/14510#issuecomment-431153707
Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6008
Build 10075: Bitcoin ABC Buildbot (legacy)
Build 10074: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 27 2019, 14:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2019, 14:37
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 27 2019, 14:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.May 27 2019, 14:44
This revision is now accepted and ready to land.May 27 2019, 14:44
teamcity added a comment.May 27 2019, 14:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6008: Diff 8914.May 27 2019, 14:51
Closed by commit rABC92889d584b61: Merge #14513: Avoid 1 << 31 (UB) in calculation of… (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 27 2019, 15:01
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC92889d584b61: Merge #14513: Avoid 1 << 31 (UB) in calculation of….
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING92889d584b61: Merge #14513: Avoid 1 << 31 (UB) in calculation of….Sep 18 2019, 23:48

Revision Contents
Changeset List

PathSize
src/
primitives/
2 lines

Diff 8914

View Options

src/primitives/transaction.h

Loading...