Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test
ClosedPublic
Actions

Authored by Mengerian on May 28 2019, 17:39.

Details

Reviewers

markblundeberg
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGa9d87ac6ade5: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test
rABCa9d87ac6ade5: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test

Summary

It's not necessary, so remove it.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cds-remove-flag-from-schnorr-test

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6042
Build 10143: Bitcoin ABC Buildbot (legacy)
Build 10142: arc lint + arc unit

Event Timeline

Mengerian created this revision.May 28 2019, 17:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2019, 17:39

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6042: Diff 8975.May 28 2019, 17:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg accepted this revision.May 29 2019, 02:20

This revision is now accepted and ready to land.May 29 2019, 02:20

Closed by commit rABCa9d87ac6ade5: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test (authored by Mengerian). · Explain WhyMay 30 2019, 16:40

This revision was automatically updated to reflect the committed changes.

Mengerian added a commit: rABCa9d87ac6ade5: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test.

Mengerian added a commit: rSTAGINGa9d87ac6ade5: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test.Sep 18 2019, 23:54

Revision Contents
Changeset List

Path

Size

src/

test/

schnorr_tests.cpp

2 lines

Diff 8975

View Options

src/test/schnorr_tests.cpp

Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr testClosedPublicActions