Page MenuHomePhabricator
Differential D3157

[Tests] Require exact match in assert_start_raises_init_eror()
ClosedPublic
Actions

Authored by Fabien on May 30 2019, 07:53.

Details

Reviewers
deadalnix
markblundeberg
Group Reviewers
Restricted Project
Maniphest Tasks
T648: Backport PR 12806 qa: Fix function names in feature_blocksdir
T568: Backport PR12718 "[Tests] Require exact match in assert_start_raises_init_error"
Commits
rSTAGING771a63de5082: [Tests] Require exact match in assert_start_raises_init_eror()
rABC771a63de5082: [Tests] Require exact match in assert_start_raises_init_eror()
Summary
This allows for exact testing, since the match can be specified with a
strict regex.
Internal details (such as exact formatting of the error message) can
still be fuzzed away by regex wildcards.

Also include later fixes:

  • PR12806 for feature_blocksdir
  • PR12810 for a typo in assert_raises_init_error()

Backport of core PR12718, PR12806 and PR12810
https://github.com/bitcoin/bitcoin/pull/12718/files
https://github.com/bitcoin/bitcoin/pull/12806/files
https://github.com/bitcoin/bitcoin/pull/12810/files

Fixes T568
Fixes T648

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12718
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6069
Build 10187: Bitcoin ABC Buildbot (legacy)
Build 10186: arc lint + arc unit

Event Timeline

Fabien created this revision.May 30 2019, 07:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 30 2019, 07:53
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 30 2019, 07:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 30 2019, 08:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6069: Diff 9009.May 30 2019, 08:09
deadalnix accepted this revision.May 30 2019, 13:34
This revision is now accepted and ready to land.May 30 2019, 13:34
markblundeberg accepted this revision.May 30 2019, 13:42
Fabien edited the summary of this revision. (Show Details)May 30 2019, 13:50
Fabien added a task: T648: Backport PR 12806 qa: Fix function names in feature_blocksdir.
Closed by commit rABC771a63de5082: [Tests] Require exact match in assert_start_raises_init_eror() (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyMay 30 2019, 13:50
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC771a63de5082: [Tests] Require exact match in assert_start_raises_init_eror().
Fabien added a commit: rSTAGING771a63de5082: [Tests] Require exact match in assert_start_raises_init_eror().Sep 18 2019, 23:53

Revision Contents
Changeset List

PathSize
test/
functional/
12 lines
27 lines
13 lines
9 lines
16 lines
test_framework/
23 lines
47 lines
4 lines
46 lines

Diff 9009

View Options

test/functional/abc-cmdline.py

Loading...
View Options

test/functional/feature_blocksdir.py

Loading...
View Options

test/functional/feature_config_args.py

Loading...
View Options

test/functional/feature_logging.py

Loading...
View Options

test/functional/feature_uacomment.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/wallet_hd.py

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...