Page MenuHomePhabricator
Differential D3175

Merge #9533: Allow non-power-of-2 signature cache sizes
ClosedPublic
Actions

Authored by jasonbcox on May 31 2019, 18:18.

Details

Reviewers
deadalnix
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGING208038885407: Merge #9533: Allow non-power-of-2 signature cache sizes
rABC208038885407: Merge #9533: Allow non-power-of-2 signature cache sizes
Summary

7482781 Allow non-power-of-2 signature cache sizes (Pieter Wuille)

Tree-SHA512: 5731c22b46c5ae81cf6d52000c28e39b243a47d96d91079942a5b5a10db214449217f71aa2195e18f8a3917cb206b04c75dc13e4522eb700a1dbf1819013ba22

Backport of Core PR9533
https://github.com/bitcoin/bitcoin/pull/9533/files

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr9533
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6102
Build 10252: Bitcoin ABC Buildbot (legacy)
Build 10251: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 31 2019, 18:18
Herald added a reviewer: deadalnix. · View Herald TranscriptMay 31 2019, 18:18
teamcity added a comment.May 31 2019, 18:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6102: Diff 9051.May 31 2019, 18:32
teamcity added a comment.May 31 2019, 18:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg requested changes to this revision.May 31 2019, 20:14
markblundeberg added a subscriber: markblundeberg.

Oh neat! Another usage of "A fast alternative to the modulo reduction"
https://lemire.me/blog/2016/06/27/a-fast-alternative-to-the-modulo-reduction/

src/cuckoocache.h
218

Do you want to use uint32_t(X) rather than (uint32_t)(X) style? You guys always nag my Diffs on that one ;-P

This revision now requires changes to proceed.May 31 2019, 20:14
jasonbcox added inline comments.May 31 2019, 23:34
src/cuckoocache.h
218

You caught me :)

jasonbcox updated this revision to Diff 9053.May 31 2019, 23:38

Fix casting style

teamcity added a comment.May 31 2019, 23:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 31 2019, 23:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6104: Diff 9053.May 31 2019, 23:54
markblundeberg accepted this revision.Jun 1 2019, 13:48
This revision is now accepted and ready to land.Jun 1 2019, 13:48
Closed by commit rABC208038885407: Merge #9533: Allow non-power-of-2 signature cache sizes (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyJun 3 2019, 20:24
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC208038885407: Merge #9533: Allow non-power-of-2 signature cache sizes.
jasonbcox added a commit: rSTAGING208038885407: Merge #9533: Allow non-power-of-2 signature cache sizes.Sep 18 2019, 23:58

Revision Contents
Changeset List

PathSize
src/
49 lines

Diff 9051

View Options

src/cuckoocache.h

Loading...