Page MenuHomePhabricator

Reintroduce the concept of virtual size from core
ClosedPublic

Authored by deadalnix on Jun 3 2019, 13:37.

Details

Summary

Bitcoin Core use the concept of virtual size to compute custom fees. We do not need to implement a ton of custom logic for our fee if we reuse that work.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
virtualsize
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6116
Build 10280: Bitcoin ABC Buildbot (legacy)
Build 10279: arc lint + arc unit

Event Timeline

markblundeberg added inline comments.
src/policy/policy.cpp
183

Given that we're using custom logic here anyway by not using GetTransactionWeight, can we use a different term than "nWeight"? (weight is such a vague term; the core version of this function weights sigops into an already-weighted "weight units").

Suggestion: nSize, nBytes, nRealSize, nRawSize, ...

This revision now requires changes to proceed.Jun 3 2019, 16:16
This revision is now accepted and ready to land.Jun 3 2019, 19:07
This revision was landed with ongoing or failed builds.Jun 3 2019, 19:12
This revision was automatically updated to reflect the committed changes.