Page MenuHomePhabricator

[LINTER] Enforce using C++ headers instead of C compatible headers
ClosedPublic

Authored by Fabien on Wed, Jun 5, 14:33.

Details

Summary

This linter replaces the C compatibility headers with the native C++
ones.

Note: it currently conflicts with clang-format (the fix gets erased).
arc lint may need to be run multiple times to fix all the issues. A
solution to these conflicts should be submitted later.

Test Plan

Add the following line:

#include <stddef.h>

Immediatly after #include <memory> in src/init.cpp.

arc lint

The linter should return an error for the newly added line and propose
the fix.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Jun 5, 14:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jun 5, 14:33
deadalnix accepted this revision.Wed, Jun 5, 15:26
This revision is now accepted and ready to land.Wed, Jun 5, 15:26
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.