Page MenuHomePhabricator

[LINTER] Enforce using C++ headers instead of C compatible headers
ClosedPublic

Authored by Fabien on Jun 5 2019, 14:33.

Details

Summary

This linter replaces the C compatibility headers with the native C++
ones.

Note: it currently conflicts with clang-format (the fix gets erased).
arc lint may need to be run multiple times to fix all the issues. A
solution to these conflicts should be submitted later.

Test Plan

Add the following line:

#include <stddef.h>

Immediatly after #include <memory> in src/init.cpp.

arc lint

The linter should return an error for the newly added line and propose
the fix.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
lint_cheader
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6160
Build 10368: Bitcoin ABC Buildbot (legacy)
Build 10367: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jun 5 2019, 15:26
This revision was landed with ongoing or failed builds.Jun 5 2019, 17:51
This revision was automatically updated to reflect the committed changes.