Page MenuHomePhabricator

add CScriptNum operator>>=
Changes PlannedPublic

Authored by markblundeberg on Sat, Jun 8, 18:55.

Details

Reviewers
deadalnix
Mengerian
Group Reviewers
Restricted Project
Maniphest Tasks
T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics)
Summary

As part of the new OP_CHECKMULTISIG mechanics, it will be useful
to have this operation.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
numrshift
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6222
Build 10491: Bitcoin ABC Teamcity Staging
Build 10490: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Sat, Jun 8, 18:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Jun 8, 18:55
Mengerian added inline comments.Sat, Jun 8, 20:44
src/test/scriptnum_tests.cpp
265

Can you also test that the disallowed cases are disallowed?

Like rhs > 64, and negative values?

markblundeberg planned changes to this revision.Sat, Jun 8, 21:50

Probably going to abandon this. The motivation was to avoid using int for a bitfield as it has implementation-defined length, but I think I will just use use asserts / tests to get rid of weird platforms.