Page MenuHomePhabricator
Differential D3263

add CScriptNum operator>>=
AbandonedPublic
Actions

Authored by markblundeberg on Jun 8 2019, 18:55.

Details

Reviewers
deadalnix
Mengerian
Group Reviewers
Restricted Project
Maniphest Tasks
T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics)
Summary

As part of the new OP_CHECKMULTISIG mechanics, it will be useful
to have this operation.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
numrshift
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6222
Build 10491: Bitcoin ABC Buildbot (legacy)
Build 10490: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jun 8 2019, 18:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2019, 18:55
teamcity added a comment.Jun 8 2019, 18:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a task: T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics).Jun 8 2019, 18:56
teamcity added a comment.Jun 8 2019, 19:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6222: Diff 9260.Jun 8 2019, 19:06
Mengerian added inline comments.Jun 8 2019, 20:44
src/test/scriptnum_tests.cpp
265

Can you also test that the disallowed cases are disallowed?

Like rhs > 64, and negative values?

markblundeberg planned changes to this revision.Jun 8 2019, 21:50
markblundeberg added a comment.Jun 9 2019, 17:13

Probably going to abandon this. The motivation was to avoid using int for a bitfield as it has implementation-defined length, but I think I will just use use asserts / tests to get rid of weird platforms.

markblundeberg abandoned this revision.Jul 9 2019, 18:57

Definitely not needed now.

Revision Contents
Changeset List

PathSize
src/
script/
6 lines
test/
11 lines

Diff 9260

View Options

src/script/script.h

Loading...
View Options

src/test/scriptnum_tests.cpp

Loading...