Page MenuHomePhabricator

utils: run commands using utf-8 string on Windows
ClosedPublic

Authored by Fabien on Sun, Jun 9, 06:43.

Details

Summary
Use unicode string to call commans

Backport of core PR13886
https://github.com/bitcoin/bitcoin/pull/13886/files

Will fix gitian windows build issue introduced in D3241.

Test Plan
make check

Build for windows:

mkdir buildcmake && cd buildcmake
cmake -GNinja .. -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake \
-DBUILD_BITCOIN_SEEDER=OFF
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Sun, Jun 9, 06:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Jun 9, 06:43
jasonbcox accepted this revision.Sun, Jun 9, 14:42
This revision is now accepted and ready to land.Sun, Jun 9, 14:42
This revision was automatically updated to reflect the committed changes.