Page MenuHomePhabricator

Merge #13877: utils: Make fs::path::string() always return utf-8 string on Windows
ClosedPublic

Authored by jasonbcox on Thu, Jun 6, 22:49.

Details

Summary

2c3eade704 Make fs::path::string() always return utf-8 string (Chun Kuan Lee)

Pull request description:

Imbue `fs::path` with `std::codecvt_utf8_utf16` at `SetupEnvironment()`, so that default string encoding will be utf-8 inside `fs::path`.

Tree-SHA512: 0cb59464d777278decbf24771fc5ff0cb2caa7bc2fe8ee5cd36c97a2324873a3caad131f08f050393b488316ee7f4ab0b28b7fa4699e41839f8e51b9867d5118

Backport of Core PR13877
https://github.com/bitcoin/bitcoin/pull/13877/files

Test Plan
make check
bitcoin-qt # sanity checks

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Thu, Jun 6, 22:49
jasonbcox added inline comments.Thu, Jun 6, 22:52
src/qt/guiutil.cpp
67 ↗(On Diff #9218)

This backport is a bit out of order, so these lines do not appear in the original PR. They are not related however, so it should be ok.

Fabien accepted this revision.Fri, Jun 7, 09:24
This revision is now accepted and ready to land.Fri, Jun 7, 09:24