[tests] Use FastRandomContext instead of boost::random::*
ClosedPublic
Actions

Authored by Fabien on Jun 10 2019, 12:08.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING838fd7ecc61d: [tests] Use FastRandomContext instead of boost::random::*
rABC838fd7ecc61d: [tests] Use FastRandomContext instead of boost::random::*

Summary

Use FastRandomContext instead of
boost::random::{mt19937,uniform_int_distribution}.

Also include the fix from PR14093 fixing type mismatch (int truncated to
bool).

Backport of core PR10547 and PR14093
https://github.com/bitcoin/bitcoin/pull/10547/files
https://github.com/bitcoin/bitcoin/pull/14093/files

Test Plan

./src/test/test_bitcoin -t scheduler_tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 10 2019, 12:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 10 2019, 12:08

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6243: Diff 9283.Jun 10 2019, 12:14

Fabien added a child revision: D3276: Avoid unintentional unsigned integer wraparounds in tests.Jun 10 2019, 12:16

Fabien planned changes to this revision.Jun 10 2019, 12:28

Fabien edited the summary of this revision. (Show Details)Jun 10 2019, 12:33

Squash the fix

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6246: Diff 9286.Jun 10 2019, 12:40

jasonbcox accepted this revision.Jun 10 2019, 16:45

This revision is now accepted and ready to land.Jun 10 2019, 16:45

Closed by commit rABC838fd7ecc61d: [tests] Use FastRandomContext instead of boost::random::* (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyJun 10 2019, 21:20

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC838fd7ecc61d: [tests] Use FastRandomContext instead of boost::random::*.

Fabien added a commit: rSTAGING838fd7ecc61d: [tests] Use FastRandomContext instead of boost::random::*.Sep 19 2019, 00:10

Revision Contents
Changeset List

Path

Size

src/

test/

scheduler_tests.cpp

19 lines

Diff 9299

View Options

src/test/scheduler_tests.cpp

[tests] Use FastRandomContext instead of boost::random::*ClosedPublicActions