Page MenuHomePhabricator

Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json
ClosedPublic

Authored by jasonbcox on Mon, Jun 10, 20:48.

Details

Summary

988ce2d Adding 'amount' label to tx_valid/tx_invalid.json files (Chris Stewart)

Tree-SHA512: 11c216c6565ecaa5ff4eb6122f87d3b28f89db52d1e473c0678f61c240e133698adb05e717bfb9d3db36409dfb230b902dca4029a58633be36c9f85e0db3d973

Backport of Core PR9350

https://github.com/bitcoin/bitcoin/pull/9350/files

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Mon, Jun 10, 20:48

Hmm looks like transaction_tests.cpp (e.g., BOOST_AUTO_TEST_CASE(tx_invalid) comment) needs to be updated as well.

Fabien accepted this revision.Tue, Jun 11, 06:03
Fabien added a subscriber: Fabien.

Agree with @markblundeberg's comment, but can be a follow up.

This revision is now accepted and ready to land.Tue, Jun 11, 06:03
markblundeberg accepted this revision.Tue, Jun 11, 13:18