Sign with SIGHASH_FORKID when UAHF is activated.
ClosedPublic
Actions

Authored by deadalnix on Jul 14 2017, 14:50.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGfda9dab6a9fb: Sign with SIGHASH_FORKID when UAHF is activated.
rABCfda9dab6a9fb: Sign with SIGHASH_FORKID when UAHF is activated.

Summary

The wallet code will sign transactions in a replay protected manner by default to ensure user funds are safe once the fork activated.

Depends on D312, D310

Test Plan

Many integration test are testing the signing code of the wallet, they are all still green.
I'd like to run live test on testnet soon, but we need to land that code first.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

signprotect

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 510
Build 510: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 14 2017, 14:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 14 2017, 14:50

Harbormaster completed remote builds in B510: Diff 816.Jul 14 2017, 14:50

I confirm this passed extended regression tests on my machine.

This revision is now accepted and ready to land.Jul 14 2017, 19:06

Closed by commit rABCfda9dab6a9fb: Sign with SIGHASH_FORKID when UAHF is activated. (authored by deadalnix, committed by deadalnix). · Explain WhyJul 14 2017, 20:24

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

12 lines

Diff 816

View Options

Sign with SIGHASH_FORKID when UAHF is activated.ClosedPublicActions