Update bitcoin-tx to use replay protected signatures
ClosedPublic
Actions

Authored by deadalnix on Jul 10 2017, 16:55.

Details

Reviewers

freetrader
sickpig
kyuupichan
awemany

Group Reviewers

Restricted Project

Commits

rSTAGING06a4da868ae5: Update bitcoin-tx to use replay protected signatures
rABC06a4da868ae5: Update bitcoin-tx to use replay protected signatures

Summary

As per title.

Test Plan

bitcoin-tx is covered in bitcoin-util-test.json , and it's still passing when generating replay protected signatures.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 10 2017, 16:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2017, 16:55

Harbormaster completed remote builds in B482: Diff 774.Jul 10 2017, 16:55

There is no test affected by this change in default mode of operation?
That would be a lack of a test case somewhere.

There is a test that sign tx and check them, and other that use a specific set of flags. I think this is not ideal, but probably good enough for now.

deadalnix added a child revision: D327: Sign with SIGHASH_FORKID when UAHF is activated..Jul 14 2017, 14:50

In D312#5449, @deadalnix wrote:

There is a test that sign tx and check them, and other that use a specific set of flags. I think this is not ideal, but probably good enough for now.

Ok, I opened an issue to add the missing test case - the code looked good to me otherwise.

This revision is now accepted and ready to land.Jul 14 2017, 15:05

Closed by commit rABC06a4da868ae5: Update bitcoin-tx to use replay protected signatures (authored by deadalnix, committed by deadalnix). · Explain WhyJul 14 2017, 15:08

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

bitcoin-tx.cpp

20 lines

Diff 821

View Options

Update bitcoin-tx to use replay protected signaturesClosedPublicActions