Page MenuHomePhabricator
Differential D312

Update bitcoin-tx to use replay protected signatures
ClosedPublic
Actions

Authored by deadalnix on Jul 10 2017, 16:55.

Details

Reviewers
freetrader
sickpig
kyuupichan
awemany
Group Reviewers
Restricted Project
Commits
rSTAGING06a4da868ae5: Update bitcoin-tx to use replay protected signatures
rABC06a4da868ae5: Update bitcoin-tx to use replay protected signatures
Summary

As per title.

Test Plan

bitcoin-tx is covered in bitcoin-util-test.json , and it's still passing when generating replay protected signatures.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
btctxforkid
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 482
Build 482: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 10 2017, 16:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2017, 16:55
Harbormaster completed remote builds in B482: Diff 774.Jul 10 2017, 16:55
freetrader edited edge metadata.Jul 10 2017, 21:19

There is no test affected by this change in default mode of operation?
That would be a lack of a test case somewhere.

deadalnix added a comment.Jul 14 2017, 11:25

There is a test that sign tx and check them, and other that use a specific set of flags. I think this is not ideal, but probably good enough for now.

deadalnix added a child revision: D327: Sign with SIGHASH_FORKID when UAHF is activated..Jul 14 2017, 14:50
freetrader accepted this revision.Jul 14 2017, 15:03
freetrader mentioned this in T65: Create a test case that exercises the default signing mode on bitcoin-tx (and fails if that is changed without changing the test).
In D312#5449, @deadalnix wrote:

There is a test that sign tx and check them, and other that use a specific set of flags. I think this is not ideal, but probably good enough for now.

Ok, I opened an issue to add the missing test case - the code looked good to me otherwise.

This revision is now accepted and ready to land.Jul 14 2017, 15:05
Closed by commit rABC06a4da868ae5: Update bitcoin-tx to use replay protected signatures (authored by deadalnix, committed by deadalnix). · Explain WhyJul 14 2017, 15:08
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
20 lines

Diff 774

View Options

src/bitcoin-tx.cpp

Loading...