Page MenuHomePhabricator

Merge #10587: Net: Fix resource leak in ReadBinaryFile(...)
AbandonedPublic

Authored by nakihito on Jun 10 2019, 21:06.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

f2fb132cb Net: Fix resource leak in ReadBinaryFile(...) (practicalswift)

Tree-SHA512: 879b9334d8bb681fa4b6f96d8ecb54e2a8948065f7be5fe7880131479c813602fc9d4a4314f043e6591e1aed50ffafa7c247362a9cdeb049b0721170e227b89a

Completes T612

Backport of Core PR10408
https://github.com/bitcoin/bitcoin/pull/10408/files

Introduces a memory leak fixed by PR10587
https://github.com/bitcoin/bitcoin/pull/10587

Includes a fix to the locale linter discussed with fabien

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10408
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6254
Build 10555: Bitcoin ABC Buildbot (legacy)
Build 10554: arc lint + arc unit

Event Timeline

nakihito created this revision.Jun 10 2019, 21:06
Owners added a reviewer: Restricted Owners Package.Jun 10 2019, 21:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 10 2019, 21:06
nakihito planned changes to this revision.Jun 10 2019, 21:20
nakihito abandoned this revision.