Page MenuHomePhabricator
Differential D3282

Merge #10177: Changed "Send" button default status from true to false
ClosedPublic
Actions

Authored by jasonbcox on Jun 10 2019, 21:23.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGc17c0116e853: Merge #10177: Changed "Send" button default status from true to false
rABCc17c0116e853: Merge #10177: Changed "Send" button default status from true to false
Summary

8c3e6c6 Changed "Send" button default status from true to false (KibbledJiveElkZoo)

Tree-SHA512: e60d7481351e88925d99b33bdb616f3c234e93ef052571b9c4a1328186ec9abb8b61b0c4299afcb731edad2634aef6b1adaad121646b6c0c56dc933662904674

Backport of Core PR10177

https://github.com/bitcoin/bitcoin/pull/10177/files

Test Plan
make check
bitcoin-qt # verify that the send tx dialog defaults to Cancel rather than Yes (should be highlighted)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10177
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6256
Build 10559: Bitcoin ABC Buildbot (legacy)
Build 10558: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jun 10 2019, 21:23
Herald added a reviewer: deadalnix. · View Herald TranscriptJun 10 2019, 21:23
jasonbcox planned changes to this revision.Jun 10 2019, 21:23
teamcity added a comment.Jun 10 2019, 21:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox requested review of this revision.Jun 10 2019, 21:26
jasonbcox edited the test plan for this revision. (Show Details)
teamcity added a comment.Jun 10 2019, 21:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6256: Diff 9302.Jun 10 2019, 21:30
Fabien accepted this revision.Jun 11 2019, 05:56
This revision is now accepted and ready to land.Jun 11 2019, 05:56
Closed by commit rABCc17c0116e853: Merge #10177: Changed "Send" button default status from true to false (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyJun 11 2019, 16:20
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCc17c0116e853: Merge #10177: Changed "Send" button default status from true to false.
jasonbcox added a commit: rSTAGINGc17c0116e853: Merge #10177: Changed "Send" button default status from true to false.Sep 19 2019, 00:12

Revision Contents
Changeset List

PathSize
src/
qt/
forms/
2 lines

Diff 9302

View Options

src/qt/forms/sendcoinsdialog.ui

Loading...