Explicitly call out updating makeseeds.py after major releases
ClosedPublic
Actions

Authored by jasonbcox on Jun 11 2019, 22:24.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING164b37e003d6: Explicitly call out updating makeseeds.py after major releases
rABC164b37e003d6: Explicitly call out updating makeseeds.py after major releases

Summary

This step is very easy to miss because there's currently no callout for a change in process for major releases regarding seeds.

Test Plan

Read it.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

seeds-major-release

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6330
Build 10707: Bitcoin ABC Buildbot (legacy)
Build 10706: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jun 11 2019, 22:24

Herald added a reviewer: deadalnix. · View Herald TranscriptJun 11 2019, 22:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6270: Diff 9327.Jun 11 2019, 22:30

deadalnix accepted this revision.Jun 12 2019, 12:56

This revision is now accepted and ready to land.Jun 12 2019, 12:56

deadalnix requested changes to this revision.Jun 12 2019, 12:57

deadalnix added inline comments.

doc/release-process.md
33 ↗	(On Diff #9327)	This will get you exactly zero peers.

This revision now requires changes to proceed.Jun 12 2019, 12:57

Should come after a major release, not during

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox retitled this revision from Explicitly call out updating makeseeds.py for major releases to Explicitly call out updating makeseeds.py after major releases.Jun 14 2019, 01:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6330: Diff 9422.Jun 14 2019, 01:06

deadalnix accepted this revision.Jun 14 2019, 13:17

This revision is now accepted and ready to land.Jun 14 2019, 13:17

Closed by commit rABC164b37e003d6: Explicitly call out updating makeseeds.py after major releases (authored by jasonbcox). · Explain WhyJun 14 2019, 18:16

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC164b37e003d6: Explicitly call out updating makeseeds.py after major releases.

jasonbcox added a commit: rSTAGING164b37e003d6: Explicitly call out updating makeseeds.py after major releases.Sep 19 2019, 00:19

Revision Contents
Changeset List

Path

Size

doc/

release-process.md

1 line

Diff 9422

View Options

Explicitly call out updating makeseeds.py after major releasesClosedPublicActions