Page MenuHomePhabricator
Differential D3311

fix `test_runner.py --help`
ClosedPublic
Actions

Authored by markblundeberg on Jun 13 2019, 03:52.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING5141d3a733fd: fix `test_runner.py --help`
rABC5141d3a733fd: fix `test_runner.py --help`
Summary

Bug from D3273.
--help would fail due to %default formatting which gets interpreted as
%d.

Test Plan

test_runner.py --help

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6300
Build 10647: Bitcoin ABC Buildbot (legacy)
Build 10646: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jun 13 2019, 03:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2019, 03:52
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jun 13 2019, 03:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg mentioned this in D3273: qa: Normalize executable location.Jun 13 2019, 03:53
teamcity added a comment.Jun 13 2019, 03:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6300: Diff 9374.Jun 13 2019, 03:58
Fabien accepted this revision.Jun 13 2019, 06:01

Thanks, the bug is due to out-of-order backport: https://github.com/bitcoin/bitcoin/pull/13944

This revision is now accepted and ready to land.Jun 13 2019, 06:01
Closed by commit rABC5141d3a733fd: fix `test_runner.py --help` (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJun 13 2019, 06:06
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC5141d3a733fd: fix `test_runner.py --help`.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING5141d3a733fd: fix `test_runner.py --help`.Sep 19 2019, 00:15

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
4 lines

Diff 9374

View Options

test/functional/test_framework/test_framework.py

Loading...