Page MenuHomePhabricator
Differential D3314

coinbaseTxns => m_coinbase_txns
ClosedPublic
Actions

Authored by deadalnix on Jun 13 2019, 15:09.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGe4c7e9c8b157: coinbaseTxns => m_coinbase_txns
rABCe4c7e9c8b157: coinbaseTxns => m_coinbase_txns
Summary

As per title.

This is done to match Bitcoin Core's naming convention.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
coinbaseTxns
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6310
Build 10667: Bitcoin ABC Buildbot (legacy)
Build 10666: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 13 2019, 15:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2019, 15:09
teamcity added a comment.Jun 13 2019, 15:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6310: Diff 9396.Jun 13 2019, 15:18
teamcity added a comment.Jun 13 2019, 15:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D3315: Make m_coinbase_txns a vector of CTransactionRef.Jun 13 2019, 15:33
jasonbcox accepted this revision.Jun 14 2019, 00:14
jasonbcox added a subscriber: jasonbcox.

For posterity: D3315 explains why the name change is not applied by simply backporting this PR: https://github.com/bitcoin/bitcoin/pull/12949/files

This revision is now accepted and ready to land.Jun 14 2019, 00:14
jasonbcox mentioned this in D3330: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp.Jun 14 2019, 00:31
Closed by commit rABCe4c7e9c8b157: coinbaseTxns => m_coinbase_txns (authored by deadalnix). · Explain WhyJun 14 2019, 13:07
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCe4c7e9c8b157: coinbaseTxns => m_coinbase_txns.
deadalnix added a commit: rSTAGINGe4c7e9c8b157: coinbaseTxns => m_coinbase_txns.Sep 19 2019, 00:18

Revision Contents
Changeset List

PathSize
src/
test/
2 lines
2 lines
4 lines
8 lines
wallet/
test/
14 lines

Diff 9396

View Options

src/test/test_bitcoin.h

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...
View Options

src/test/txindex_tests.cpp

Loading...
View Options

src/test/txvalidationcache_tests.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...