Page MenuHomePhabricator

Replumb ibd.sh to prepare for better post-IBD checks
ClosedPublic

Authored by jasonbcox on Jun 17 2019, 22:50.

Details

Summary

With the current design of ibd.sh, exiting the IBD subshell early (in the
future case of adding additional tests/checks) would result in bitcoind not exiting
as expected. This patch replumbs ibd.sh such that failures in the IBD subshell or
bitcoind properly fail the script as expected.

Post IBD checks will be added in an upcoming diff.

Test Plan

TeamCity IBD

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ibd-better-subshell
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6390
Build 10827: Bitcoin ABC Buildbot (legacy)
Build 10826: arc lint + arc unit

Event Timeline

Fix SIGPIPE failure, but without ignoring other pipeline failures

Apparently tail has multiple failure modes for broken pipes, so trapping only catches one of them.
Using set +o pipefail instead.

This revision is now accepted and ready to land.Jun 24 2019, 09:39