This has been left apart due to the required .raw to .h transformation.
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING20267a606f2d: [CMAKE] Build checkblock benchmark
rABC20267a606f2d: [CMAKE] Build checkblock benchmark
ninja bench-bitcoin
The benchmark should build and run with no issue.
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cmake_checkblock_raw_header
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 6476 Build 10999: Bitcoin ABC Buildbot (legacy) Build 10998: arc lint + arc unit
Event Timeline
src/bench/CMakeLists.txt | ||
---|---|---|
22 ↗ | (On Diff #9523) | I think a custom command is a better fit here, as there is no point in building the raw.h file apart from the whole bench executable (the same is used for generate_header.py, for the same reason I guess). |
src/bench/data/convert-raw-to-header.sh | ||
10 ↗ | (On Diff #9523) | Good idea ! Using a redirection will make the script much simpler. |
src/bench/data/convert-raw-to-header.sh | ||
---|---|---|
6 | There are no dependency on hexdump. I don't understand why the approach taken by src/test/data/generate_header.py is not preferable. |
src/bench/data/convert-raw-to-header.sh | ||
---|---|---|
6 | The dependency exists as long as autotools is still supported, the script is just the direct translation of the Makefile.bench.include scipt (only special autotools variables names are adapted). |
src/bench/data/convert-raw-to-header.py | ||
---|---|---|
18 ↗ | (On Diff #9660) | En Taro Adun! |