Page MenuHomePhabricator

Use a unique index for the running jobs in case of duplicated names
ClosedPublic

Authored by Fabien on Jun 19 2019, 12:15.

Details

Summary

The core's PR10374 allows to run the same test several times with a
single call to test_runner.py, by duplicating the test name in the
arguments list. The test_runner.py code has diverged from core, and some
changes will prevent from running duplicated tests.

The test_runner.py script maintains a set of running jobs, indexed by
their test name. This diffs changes the set to a list, and uses a tuple
(test number, test name) as the key. This also requires to pass the
number to the TestResult class in order to rebuild the key when the
job needs to be removed from the list.

Test Plan
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
test_runner_index_tuple
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6400
Build 10847: Bitcoin ABC Buildbot (legacy)
Build 10846: arc lint + arc unit