Page MenuHomePhabricator
Differential D3417

[sigencoding] refactor schnorr size check
ClosedPublic
Actions

Authored by markblundeberg on Jun 26 2019, 04:20.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics)
Commits
rSTAGING77a1913a3754: [sigencoding] refactor schnorr size check
rABC77a1913a3754: [sigencoding] refactor schnorr size check
Summary

(in preparation for adding a Schnorr-only encoding checker)

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Jun 26 2019, 04:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 26 2019, 04:20
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jun 26 2019, 04:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a child revision: D3265: add new encoding checker for Schnorr sigs.Jun 26 2019, 04:22
markblundeberg added a task: T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics).Jun 26 2019, 04:25
teamcity added a comment.Jun 26 2019, 04:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6487: Diff 9675.Jun 26 2019, 04:27
deadalnix accepted this revision.Jun 26 2019, 23:02

This makes the code more semantically driven. Me gusta :)

This revision is now accepted and ready to land.Jun 26 2019, 23:02
Closed by commit rABC77a1913a3754: [sigencoding] refactor schnorr size check (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJun 28 2019, 14:41
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC77a1913a3754: [sigencoding] refactor schnorr size check.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING77a1913a3754: [sigencoding] refactor schnorr size check.Sep 19 2019, 00:42

Revision Contents
Changeset List

PathSize
src/
script/
8 lines

Diff 9766

View Options

src/script/sigencoding.cpp

Loading...