Fix struct vs class mismatch for Amount
ClosedPublic
Actions

Authored by Fabien on Jun 26 2019, 07:32.

Details

Reviewers

deadalnix
jasonbcox
markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGINGe80c6110fd73: Fix struct vs class mismatch for Amount
rABCe80c6110fd73: Fix struct vs class mismatch for Amount

Summary

The recently introduced (D3344 and D3365) forward declarations for
class Amount conflict with the declared struct Amount from amount.h.
This throws -Wmismatched-tags warnings.

Test Plan

make check
ninja check

Make sure there is no -Wmismatched-tags warning

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 26 2019, 07:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 26 2019, 07:32

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6490: Diff 9679.Jun 26 2019, 07:40

jasonbcox accepted this revision.Jun 26 2019, 15:33

This revision is now accepted and ready to land.Jun 26 2019, 15:33

my bad!

Closed by commit rABCe80c6110fd73: Fix struct vs class mismatch for Amount (authored by Fabien). · Explain WhyJun 26 2019, 16:08

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe80c6110fd73: Fix struct vs class mismatch for Amount.

Fabien added a commit: rSTAGINGe80c6110fd73: Fix struct vs class mismatch for Amount.Sep 19 2019, 00:35

Revision Contents
Changeset List

Path

Size

src/

consensus/

tx_verify.h

2 lines

core_io.h

2 lines

Diff 9690

View Options

src/consensus/tx_verify.h