Page MenuHomePhabricator

Handle various leftover from PR10321
ClosedPublic

Authored by deadalnix on Jun 27 2019, 17:28.

Details

Summary

For some reason, InsecureRand32 was skipped and various other changes were not up to the orginal.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10321
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6533
Build 11113: Bitcoin ABC Buildbot (legacy)
Build 11112: arc lint + arc unit

Event Timeline

deadalnix retitled this revision from Handle variosu leftover from PR10321 to Handle various leftover from PR10321.Jun 27 2019, 23:04

Revert prevector_tester ctor.

jasonbcox requested changes to this revision.Jun 28 2019, 16:27
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/test/coins_tests.cpp
169

This either needs to be consistent throughout this file, or matching the original PR.
Original PR uses InsecureRandBits(6) here, but see my other comment below how the opposite is true for a similar change.

imo InsecureRandBits(6) is easier to read

311

Original PR: InsecureRand32() & 0x3F

This revision now requires changes to proceed.Jun 28 2019, 16:27

rebase and fix details to match the PR better

This revision is now accepted and ready to land.Jul 1 2019, 21:22
This revision was automatically updated to reflect the committed changes.