Page MenuHomePhabricator

Merge #11480: [ui] Add toggle for unblinding password fields
ClosedPublic

Authored by jasonbcox on Jun 28 2019, 18:21.

Details

Summary

ff35de8 [ui] Add toggle for unblinding password fields (Thomas Snider)

Pull request description:

Proposed change for adding the ability to toggle password visibility in the password dialog.  This is similar to functionality in most password managers and is specifically added with the use case of password managers in mind - the password in that case is likely pasted twice into both the new password and confirm password fields.

If this is a welcome change, I am open to suggestions on rearranging the layout.

Tree-SHA512: 1823f356f8f941cc584c44de264433e9a573cb8a358efa300a412c4458b5564d8d193969be40859195cf9c8d6768eee895ee22440d51db4f09175f9b4e28bced

Backport of Core PR11480

https://github.com/bitcoin/bitcoin/pull/11480/files

Test Plan
make check
bitcoin-qt -> Encrypt Wallet # verified the toggle shows the password as expected

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Jun 28 2019, 19:33