Restore and backport missing changes from clientversion.h
ClosedPublic
Actions

Authored by jasonbcox on Jul 1 2019, 18:46.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGa063863a589f: Restore and backport missing changes from clientversion.h
rABCa063863a589f: Restore and backport missing changes from clientversion.h

Summary

Some lines were removed erroneously in D2111
Also backports:

Missing change from PR10155: https://github.com/bitcoin/bitcoin/pull/10155/commits/08d9aee3ebc2c2401c4137e0575bdbbe056f5cae
Build fix PR10168: https://github.com/bitcoin/bitcoin/pull/10168/files

Test Plan

make check
ninja check

# for both the make and cmake builds:
bitcoind --version
bitcoin-qt --version
bitcoin-cli --version

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr10155-restore

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6600
Build 11247: Bitcoin ABC Buildbot (legacy)
Build 11246: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jul 1 2019, 18:46

Herald added a reviewer: deadalnix. · View Herald TranscriptJul 1 2019, 18:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien accepted this revision.Jul 1 2019, 18:50

This revision is now accepted and ready to land.Jul 1 2019, 18:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6600: Diff 9870.Jul 1 2019, 18:54

Closed by commit rABCa063863a589f: Restore and backport missing changes from clientversion.h (authored by jasonbcox). · Explain WhyJul 1 2019, 18:56

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCa063863a589f: Restore and backport missing changes from clientversion.h.

jasonbcox added a commit: rSTAGINGa063863a589f: Restore and backport missing changes from clientversion.h.Sep 19 2019, 00:49

Revision Contents
Changeset List

Path

Size

src/

clientversion.h

9 lines

Diff 9870

View Options

Restore and backport missing changes from clientversion.hClosedPublicActions