Ensure that CDataStream never reads from empty buffers.
ClosedPublic
Actions

Authored by deadalnix on Jul 20 2017, 18:14.

Details

Reviewers

CCulianu
freetrader

Group Reviewers

Restricted Project

Commits

rSTAGING56f32c636ff8: Ensure that CDataStream never reads from empty buffers.
rABC56f32c636ff8: Ensure that CDataStream never reads from empty buffers.

Summary

On some systems, current implementation of CDataStream sometime can read from empty buffers.

Test Plan

Added test cases. Checked with @CCulianu that the test case indeed trigger the bug on some specific systems and made sure the patch fixes it.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 20 2017, 18:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 20 2017, 18:14

Harbormaster completed remote builds in B549: Diff 887.Jul 20 2017, 18:14

Ok, tested with your new "with arrays" addition.. everything checks out. On my Travis-work-alike system your test case failed, but with the patch to streams.h, your test case passed. Looks great.

This revision is now accepted and ready to land.Jul 20 2017, 18:22

Closed by commit rABC56f32c636ff8: Ensure that CDataStream never reads from empty buffers. (authored by deadalnix, committed by deadalnix). · Explain WhyJul 20 2017, 18:27

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

streams.h

29 lines

test/

streams_tests.cpp

18 lines

Diff 888

View Options

src/streams.h