HomePhabricator

Ensure that CDataStream never reads from empty buffers.
56f32c636ff8Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Ensure that CDataStream never reads from empty buffers.

Summary: On some systems, current implementation of CDataStream sometime can read from empty buffers.

Test Plan: Added test cases. Checked with @CCulianu that the test case indeed trigger the bug on some specific systems and made sure the patch fixes it.

Reviewers: CCulianu, freetrader, #bitcoin_abc

Reviewed By: CCulianu, #bitcoin_abc

Subscribers: CCulianu

Differential Revision: https://reviews.bitcoinabc.org/D355

Details

Provenance
deadalnixAuthored on Jul 20 2017, 17:15
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Reviewer
Restricted Project
Differential Revision
D355: Ensure that CDataStream never reads from empty buffers.
Parents
rSTAGINGedfe4b0574a2: Align ABC spec docs with UAHF specs of 2017-07-16
Branches
Unknown
Tags
Unknown