Page MenuHomePhabricator

Various nits in the Qt code
ClosedPublic

Authored by deadalnix on Jul 4 2019, 19:42.

Details

Summary

As per title.

Test Plan

Run bitcoin-qt and perform various actions. It looks like it is working.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Jul 4 2019, 19:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2019, 19:42
markblundeberg requested changes to this revision.Jul 5 2019, 16:26
markblundeberg added a subscriber: markblundeberg.

Is there a better way to do those else clauses? Otherwise all good...

src/qt/sendcoinsentry.cpp
231 ↗(On Diff #9986)

These broken up else clauses feel a bit nasty to me ... is this considered good style?

This revision now requires changes to proceed.Jul 5 2019, 16:26
deadalnix requested review of this revision.Jul 6 2019, 14:07
deadalnix added inline comments.
src/qt/sendcoinsentry.cpp
231 ↗(On Diff #9986)

This is what is used in other parts of the codebase, such as net_processing.cpp

Fabien accepted this revision.Jul 6 2019, 14:14
markblundeberg accepted this revision.Jul 6 2019, 20:26
markblundeberg added inline comments.
src/qt/sendcoinsentry.cpp
231 ↗(On Diff #9986)

OK then :)

This revision is now accepted and ready to land.Jul 6 2019, 20:26
This revision was automatically updated to reflect the committed changes.