Page MenuHomePhabricator
Differential D3552

Various nits in the Qt code
ClosedPublic
Actions

Authored by deadalnix on Jul 4 2019, 19:42.

Details

Reviewers
markblundeberg
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGf4d83da10303: Various nits in the Qt code
rABCf4d83da10303: Various nits in the Qt code
Summary

As per title.

Test Plan

Run bitcoin-qt and perform various actions. It looks like it is working.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
qtbraces
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6670
Build 11387: Bitcoin ABC Buildbot (legacy)
Build 11386: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 4 2019, 19:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2019, 19:42
teamcity added a comment.Jul 4 2019, 19:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 4 2019, 19:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6670: Diff 9986.Jul 4 2019, 19:49
markblundeberg requested changes to this revision.Jul 5 2019, 16:26
markblundeberg added a subscriber: markblundeberg.

Is there a better way to do those else clauses? Otherwise all good...

src/qt/sendcoinsentry.cpp
231

These broken up else clauses feel a bit nasty to me ... is this considered good style?

This revision now requires changes to proceed.Jul 5 2019, 16:26
deadalnix requested review of this revision.Jul 6 2019, 14:07
deadalnix added inline comments.
src/qt/sendcoinsentry.cpp
231

This is what is used in other parts of the codebase, such as net_processing.cpp

Fabien accepted this revision.Jul 6 2019, 14:14
markblundeberg accepted this revision.Jul 6 2019, 20:26
markblundeberg added inline comments.
src/qt/sendcoinsentry.cpp
231

OK then :)

This revision is now accepted and ready to land.Jul 6 2019, 20:26
Closed by commit rABCf4d83da10303: Various nits in the Qt code (authored by deadalnix). · Explain WhyJul 6 2019, 23:46
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCf4d83da10303: Various nits in the Qt code.
deadalnix added a commit: rSTAGINGf4d83da10303: Various nits in the Qt code.Sep 19 2019, 01:00

Revision Contents
Changeset List

Diff 9986

View Options

src/qt/coincontroldialog.cpp

Loading...
View Options

src/qt/paymentserver.cpp

Loading...
View Options

src/qt/receiverequestdialog.cpp

Loading...
View Options

src/qt/sendcoinsentry.cpp

Loading...
View Options

src/qt/transactiondesc.cpp

Loading...
View Options

src/qt/walletframe.cpp

Loading...