Fix memory leak in work_comparator_tests.cpp
ClosedPublic
Actions

Authored by Fabien on Jul 5 2019, 18:48.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING45e5a3edaabf: Fix memory leak in work_comparator_tests.cpp
rABC45e5a3edaabf: Fix memory leak in work_comparator_tests.cpp

Summary

The CBlockIndex are never freed.

Test Plan

Build with asan, then:

./src/test/test_bitcoin -t work_comparator_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_work_comparator_tests_memleak

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6689
Build 11425: Bitcoin ABC Buildbot (legacy)
Build 11424: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 5 2019, 18:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2019, 18:48

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6689: Diff 10018.Jul 5 2019, 18:55

jasonbcox accepted this revision.Jul 5 2019, 18:59

This revision is now accepted and ready to land.Jul 5 2019, 18:59

Closed by commit rABC45e5a3edaabf: Fix memory leak in work_comparator_tests.cpp (authored by Fabien). · Explain WhyJul 5 2019, 19:43

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC45e5a3edaabf: Fix memory leak in work_comparator_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien added a commit: rSTAGING45e5a3edaabf: Fix memory leak in work_comparator_tests.cpp.Sep 19 2019, 00:58

Revision Contents
Changeset List

Path

Size

src/

test/

work_comparator_tests.cpp

10 lines

Diff 10018

View Options

src/test/work_comparator_tests.cpp

Fix memory leak in work_comparator_tests.cppClosedPublicActions