Page MenuHomePhabricator

Use cstdint in generated test headers
ClosedPublic

Authored by deadalnix on Jul 7 2019, 13:09.

Details

Summary

It is more in line with the style we are adopting.

Test Plan
make clean
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Jul 7 2019, 13:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2019, 13:09
markblundeberg added inline comments.
src/test/CMakeLists.txt
132 ↗(On Diff #10047)

I can't see what's changing here, also... unrelated?

markblundeberg requested changes to this revision.Jul 8 2019, 01:36
This revision now requires changes to proceed.Jul 8 2019, 01:36
deadalnix requested review of this revision.Jul 8 2019, 12:46
deadalnix added inline comments.
src/test/CMakeLists.txt
132 ↗(On Diff #10047)

It's a whitespace change. Someone misconfigured their text editor.

Fabien accepted this revision.Jul 8 2019, 12:53
markblundeberg accepted this revision.Jul 8 2019, 13:18
markblundeberg added inline comments.
src/test/CMakeLists.txt
132 ↗(On Diff #10047)

Oh yeah I can see it now (by clicking 'view left file' and 'view right file'). Annoyingly, phab renders a tab as two spaces so they look identical here, hah.

This revision is now accepted and ready to land.Jul 8 2019, 13:18
This revision was automatically updated to reflect the committed changes.